Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prom2teams could go on diet... #110

Closed
1 task
dortegau opened this issue Apr 10, 2019 · 0 comments
Closed
1 task

prom2teams could go on diet... #110

dortegau opened this issue Apr 10, 2019 · 0 comments
Assignees

Comments

@dortegau
Copy link
Member

dortegau commented Apr 10, 2019

Prerequisites

Description

There are some things that could be improved:

  • We could use Alpine Linux instead of Debian
  • build-essential is not needed, the image only needs gcc
  • We should remove cache after needed packages installation
  • We could add a Docker ignore to ignore some files not needed in the context
  • As multiple ADD commands are executed, this creates a multilayer that could be improved using a single COPY command.

Additional Information

https://docs.docker.com/develop/develop-images/dockerfile_best-practices/

@dortegau dortegau self-assigned this Apr 10, 2019
dortegau added a commit that referenced this issue Apr 10, 2019
dortegau added a commit that referenced this issue Apr 12, 2019
dortegau added a commit that referenced this issue Apr 27, 2019
@dortegau dortegau closed this as completed May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant