-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a break in change label when renaming varibales #62
Comments
Ok I will add the 1.0.1
Le dim. 8 mars 2020 à 12:36, hmlafrugalitas <notifications@github.com> a
écrit :
… In the last version 1.0.1, some variables was renamed causing a break in
the existing code.
- Renamed CurrentTheme to UsedTheme in NeumorphicTheme (Dark, Light,
System)
- Renamed NeumorphicTheme.getCurrentTheme(context) to
NeumorphicTheme.currentTheme(context)
Can you please add a tag for such change so when we read the change log we
can detect them.
Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#62?email_source=notifications&email_token=ABL5AXCHCW7YDEBI6FEG3Y3RGN7LXA5CNFSM4LDYTW32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ITLYA3Q>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABL5AXGCHPNUJFEFZGZMN2DRGN7LXANCNFSM4LDYTW3Q>
.
|
BTW it's in the changelog.md
Le dim. 8 mars 2020 à 12:36, hmlafrugalitas <notifications@github.com> a
écrit :
… In the last version 1.0.1, some variables was renamed causing a break in
the existing code.
- Renamed CurrentTheme to UsedTheme in NeumorphicTheme (Dark, Light,
System)
- Renamed NeumorphicTheme.getCurrentTheme(context) to
NeumorphicTheme.currentTheme(context)
Can you please add a tag for such change so when we read the change log we
can detect them.
Thanks.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#62?email_source=notifications&email_token=ABL5AXCHCW7YDEBI6FEG3Y3RGN7LXA5CNFSM4LDYTW32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ITLYA3Q>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABL5AXGCHPNUJFEFZGZMN2DRGN7LXANCNFSM4LDYTW3Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the last version 1.0.1, some variables was renamed causing a break in the existing code.
Can you please add a tag for such change so when we read the change log we can detect them.
Thanks.
The text was updated successfully, but these errors were encountered: