Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a break in change label when renaming varibales #62

Closed
hmlafrugalitas opened this issue Mar 8, 2020 · 3 comments
Closed

Add a break in change label when renaming varibales #62

hmlafrugalitas opened this issue Mar 8, 2020 · 3 comments

Comments

@hmlafrugalitas
Copy link

In the last version 1.0.1, some variables was renamed causing a break in the existing code.

  • Renamed CurrentTheme to UsedTheme in NeumorphicTheme (Dark, Light, System)
  • Renamed NeumorphicTheme.getCurrentTheme(context) to NeumorphicTheme.currentTheme(context)

Can you please add a tag for such change so when we read the change log we can detect them.

Thanks.

@florent37
Copy link
Member

florent37 commented Mar 8, 2020 via email

@florent37
Copy link
Member

florent37 commented Mar 8, 2020 via email

@florent37
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants