Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use offset for query result pagination #65

Closed
hongyuanjia opened this issue Sep 19, 2022 · 0 comments · Fixed by #73
Closed

Use offset for query result pagination #65

hongyuanjia opened this issue Sep 19, 2022 · 0 comments · Fixed by #73
Assignees
Labels
Milestone

Comments

@hongyuanjia
Copy link
Member

Currently, init_cmip6_index() only returns the first 10,000 records.

epwshiftr/R/esgf.R

Lines 446 to 452 in 09827d4

if (nrow(qd) == 10000L) {
warning("The dataset query returns 10,000 results which ",
"hits the maximum record limitation of a single query using ESGF search RESTful API. ",
"It is possible that the returned Dataset query responses are not complete. ",
"It is suggested to examine and refine your query."
)
}

It is enough for most use cases. But it will still be good to implement pagination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant