Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View-source in VR mode isn't necessary #2

Closed
andymartinwork opened this issue Jan 16, 2016 · 5 comments
Closed

View-source in VR mode isn't necessary #2

andymartinwork opened this issue Jan 16, 2016 · 5 comments

Comments

@andymartinwork
Copy link

It's only on one of the screens, and looks very bad in VR.

@weddingdj
Copy link
Contributor

I don't see the view-source link in VR mode, only in desktop mode. I tested in Firefox Nightly.

@cvan
Copy link

cvan commented Jan 19, 2016

I see it here.

I would add this style:

.view-source:fullscreen {
  display: none;
}

In the future, we'll have events so you know when you're truly in "VR Mode" (not just assuming that if we're in Fullscreen that we're also in VR Mode).

@weddingdj
Copy link
Contributor

Sure, will do, but I would not see the View Source when in VR mode.

@cvan
Copy link

cvan commented Jan 19, 2016

Sure, will do, but I would not see the View Source when in VR mode.

in VR mode, you re-create the link using A-Frame (with an <a-entity>, for example). otherwise, it won't be clickable anyway. (and in Chrome the link won't be visible at all because Chrome fullscreens the <canvas> not the entire page.)

@weddingdj
Copy link
Contributor

The view source link was supposed to be visible when not being in fullscreen or VR mode, just when someone lands on the page. I added it to let people easily view the source code, like you do in your a-frame examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants