You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
In go the convention is to call constructor functions starting with New. I
think func (hdr *fchdr) FillHdr(...) should be rewritten as func NewHdr(...), and func (hdr *fchdr) fromBytes(...) as func NewHdrFromBytes(...).
The text was updated successfully, but these errors were encountered:
I have fixed FillHdr -> NewHdr. However, I don't see necessary to change fromBytes as I already do it in getKeyFCFromType(). This function is a constructor and uses fromBytes to fill the contents.
In go the convention is to call constructor functions starting with
New
. Ithink
func (hdr *fchdr) FillHdr(...)
should be rewritten asfunc NewHdr(...)
, andfunc (hdr *fchdr) fromBytes(...)
asfunc NewHdrFromBytes(...)
.The text was updated successfully, but these errors were encountered: