Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Constructors #17

Open
druiz0992 opened this issue Jun 11, 2020 · 2 comments
Open

Constructors #17

druiz0992 opened this issue Jun 11, 2020 · 2 comments
Assignees

Comments

@druiz0992
Copy link
Contributor

In go the convention is to call constructor functions starting with New. I
think func (hdr *fchdr) FillHdr(...) should be rewritten as func NewHdr(...), and func (hdr *fchdr) fromBytes(...) as func NewHdrFromBytes(...).

@druiz0992 druiz0992 self-assigned this Jun 11, 2020
@druiz0992
Copy link
Contributor Author

Fixed in 8cef622

I have fixed FillHdr -> NewHdr. However, I don't see necessary to change fromBytes as I already do it in getKeyFCFromType(). This function is a constructor and uses fromBytes to fill the contents.

@druiz0992 druiz0992 assigned ed255 and unassigned druiz0992 Jun 13, 2020
@druiz0992
Copy link
Contributor Author

Edu, check my comment above and let me know if you agree.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants