Skip to content
This repository has been archived by the owner on Jul 14, 2020. It is now read-only.

Exception does not show anything in logs ( try/finally)-IdentityServerAuthenticationHandler #116

Closed
lisberPontes opened this issue May 2, 2019 · 4 comments

Comments

@lisberPontes
Copy link
Contributor

Exception does not show anything in logs ( try/finally)-IdentityServerAuthenticationHandler

After some hourse digging why something didn't work properly in localhost (it ended up been a missconfiguration in my ids).

I took the sourcecode and saw that there's a try/finally block without a catch (in case something happen just log it).

@lisberPontes
Copy link
Contributor Author

I've a commit I wish to send you as a PR:
image

May I have permissions to create a remote branch and send you a PR ?

Regards,

@leastprivilege
Copy link
Member

yes please.

@lisberPontes
Copy link
Contributor Author

yes please.

I still cannot publish my remote branch in order to send you a PR :(

image

May you please give permissions to my account so that I can publish my remote branch?
Regards,
Lisber

@leastprivilege
Copy link
Member

You don't need any permissions to do a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants