Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the version of FastAPI fixed in the install_requires? #141

Closed
gukoff opened this issue Jun 14, 2020 · 2 comments
Closed

Why is the version of FastAPI fixed in the install_requires? #141

gukoff opened this issue Jun 14, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gukoff
Copy link

gukoff commented Jun 14, 2020

Currently fastapi/pydantic versions are fixed in setup.py:

requirements = [
    'fastapi==0.52.0',
    'pydantic==1.4',
    'contextvars;python_version<"3.7"'
]

Is there a reason not to use >= instead?

If compatibility is a concern, it's possible to test against different versions of FastAPI on TravisCI.

@levchik
Copy link
Contributor

levchik commented Jun 18, 2020

Hi, @gukoff

The reason for this is that we've had some issues with fastapi and pydantic new minor versions broking code in this repo. Since both packages are pretty much mature now, I think we can remove hard version pinning and implement your suggested changes.

I think that I will have time to make changes myself no earlier than in a week or so, but you are very welcome to send PR.

@levchik levchik added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 18, 2020
@levchik
Copy link
Contributor

levchik commented Jun 24, 2020

Solved by ccb6a40

@levchik levchik closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants