Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

has_required_permisions typo or bypass of naming conflict? #156

Closed
rsommerard opened this issue Oct 27, 2020 · 3 comments
Closed

has_required_permisions typo or bypass of naming conflict? #156

rsommerard opened this issue Oct 27, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@rsommerard
Copy link
Contributor

  • FastAPI Contrib version: 0.2.8
  • FastAPI version: 0.61.1
  • Python version: 3.8
  • Operating System: Ubuntu 20.04

has_required_permisions method from BasePermission class should be has_required_permissions, is it a typo or is it a trick to bypass a naming conflict?
@levchik
Copy link
Contributor

levchik commented Oct 29, 2020

Hi @rsommerard , I guess it is actually a typo! Thanks for noticing, would you mind making a PR?

@levchik levchik added the bug Something isn't working label Oct 29, 2020
@rsommerard
Copy link
Contributor Author

Yep, I will do the change and provide a PR.

@levchik
Copy link
Contributor

levchik commented Nov 2, 2020 •
edited

Closed by #157

Thank you @rsommerard !

@levchik levchik closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@levchik @rsommerard