Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local_dot_product_cuda fails when queries and keys have different lengths #98

Open
tridao opened this issue Aug 8, 2021 · 0 comments
Open

Comments

@tridao
Copy link

tridao commented Aug 8, 2021

There's an error when local_dot_product_cuda is called with different query and key lengths, because of a wrong reshape on this line:


I think instead of

keys.reshape({N*H, L, E})

it should be

keys.reshape({N*H, S, E})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant