Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PubSub functions useable by child classes #1507

Merged
merged 1 commit into from Sep 8, 2016

Conversation

mapkyca
Copy link
Member

@mapkyca mapkyca commented Sep 8, 2016

Here's what I fixed or added:

Change private methods to protected

Here's why I did it:

This is good practice, and necessary as I wanted to implement my own pubsub functions and not rewrite the wheel.

@mapkyca
Copy link
Member Author

mapkyca commented Sep 8, 2016

Minor change, but high priority, so merging myself (cc @benwerd )

@mapkyca mapkyca merged commit 5593071 into idno:master Sep 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant