Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin no longer works with known master #7

Closed
zoglesby opened this issue Jul 8, 2019 · 1 comment · Fixed by #8
Closed

Plugin no longer works with known master #7

zoglesby opened this issue Jul 8, 2019 · 1 comment · Fixed by #8

Comments

@zoglesby
Copy link

zoglesby commented Jul 8, 2019

Fatal Error: /path/to/known/IdnoPlugins/S3/Main.php:21 - "Uncaught Error: Class 'Symfony\Component\ClassLoader\UniversalClassLoader' not found in /var/www/known/known/IdnoPlugins/S3/Main.php:21

It seems that this is because the change to composer, I tried adding class-loader to my composer.json and then requiring UniversalClassLoader in the Main.php of this plugin, but it appears to be missing in the most recent version.

I am going to poke around at this more later, but wanted to capture the issue for now.

@mapkyca
Copy link
Member

mapkyca commented Jul 9, 2019

The S3 plugin is going to need a little love in order to work with modern core, but it shouldn't need major changes.

You don't need the universal class loader. Either specify the s3 library in a composer json, or use SPL to load it.

You'll not be able to override the filesystem by hacky injection, so you're going to need to specify a filesystem class via config.ini.

You'll also probably want to implement CDNStorable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants