Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expose DB id's to the outside world #4

Open
Nico-van-der-Zijden opened this issue May 27, 2022 · 4 comments
Open

Don't expose DB id's to the outside world #4

Nico-van-der-Zijden opened this issue May 27, 2022 · 4 comments
Labels
requirement Required feature

Comments

@Nico-van-der-Zijden
Copy link

Add a Guid to the scener/releases/etc etc so that can be used to retrieve a specific release/scener etc.
Also add created/modified/deleted columns for those kind of tables

@Nico-van-der-Zijden Nico-van-der-Zijden added the requirement Required feature label May 27, 2022
@idolpx
Copy link
Owner

idolpx commented May 27, 2022

Ok... I'm going to split this into two individual requirements.
What is the reasoning for using a GUID rather than sequential IDs?

@Nico-van-der-Zijden
Copy link
Author

You should use both in your DB where the id is the pk, you can use the id server side but when exposing the data through an api you should use the guid instead of the id.
It's more of a security thing, if you expose the id of a record someone can easily decrease/increase that id and possibly retrieve data which they shouldn't, guessing a corect guid is a 'bit' harder.

@idolpx
Copy link
Owner

idolpx commented May 27, 2022

That makes sense. I guess we need to define what information should not be accessible.
I don't think there is anything about a release, group, scener, handle, event, bbs, or sid that needs to be protected.

Of course a user's login info would need to be protected when logging in via the API.

@idolpx
Copy link
Owner

idolpx commented Jun 8, 2022

I've added "uuid" to the major types in the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requirement Required feature
Projects
None yet
Development

No branches or pull requests

2 participants