Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move idom.widgets.hotswap to testing utils #866

Closed
Archmonger opened this issue Dec 31, 2022 Discussed in #865 · 0 comments · Fixed by #876
Closed

Move idom.widgets.hotswap to testing utils #866

Archmonger opened this issue Dec 31, 2022 Discussed in #865 · 0 comments · Fixed by #876
Labels
priority-3-low May be resolved one any timeline. type-refactor About improving code structure.
Milestone

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Dec 31, 2022

Discussed in #865


Originally posted by Archmonger December 30, 2022
Ever since we've formalized support for conditionally rendered components, hotswap seems to have become a rather pointless utility.

This conversation is to discuss whether to deprecate/remove it.


Originally posted by rmorshea December 30, 2022
The primary function isn't really to facilitate conditional rendering. Rather, it's to allow you to swap components from outside the normal rendering flow. With that said, it's uses are pretty niche. At the moment it has one usage in IDOM's testing utilities. I'd say it would make sense to turn it into a private util in idom.testing.backend.

@Archmonger Archmonger added the priority-3-low May be resolved one any timeline. label Dec 31, 2022
@Archmonger Archmonger added this to the 1.0 milestone Dec 31, 2022
@Archmonger Archmonger added the type-refactor About improving code structure. label Jan 4, 2023
@rmorshea rmorshea mentioned this issue Jan 12, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-3-low May be resolved one any timeline. type-refactor About improving code structure.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant