Creating New Generic File Upload Controller

[Aman-Gupta-404]

Working on the feature to upload files (issue #412 )

• In Progress

[salahlalami]

@Aman-Gupta-404 any update , please commit your progress , and make pr as draft

[Aman-Gupta-404]

Hi @salahlalami, I have created the files and the middleware for uploading the files. When I am testing the API using postman, I am getting a production issue, not sure why it is happening. Can use your help there.

Updates that are done

1. created files according to the steps mentioned in the issue feat : Create New Generic File Upload Controller #412
2. created an upload model in the model folder
3. Created 3 middlewares, one to create public file models, second one to create private file models, and third to upload the file using multer.
4. added API end points in the routes file, to upload public and private files separately.

Please do let me know if there are any issues or anything that I can update, I will do that

[salahlalami]

filename = orginalFileName+'-'+uniqueFileID+.${fileExtension}`;

orginalFileName = orginalFileName -> to lower case -> then use "npmjs.com/package/transliteration " to convert english-char
uniqueFileID = unique ID of 5 chars including [a-z,0-9]

[salahlalami]

type boolean
default false

[salahlalami]

@Aman-Gupta-404 please review requested change ,

[Aman-Gupta-404]

Hi @salahlalami, I have reviewed and made the changes to according to your request

Apart from the changes, a few things I would like to mention.

• I have changed the order of the middlewares in the /routes/eprRoutes/eprApi.js, the multer middle ware is being used first.

Do let me know if there are any issues with this code, can work on it

[salahlalami]

@Aman-Gupta-404

1. could you add option to add multiply files
2. Add option to add allowed file , ex only image

[Aman-Gupta-404]

Hey @salahlalami, so regarding this

Can you tell me how do I make the option accessible from the backend, like should the options come from request params or from request body?
Secondly, can you tell me if a user is uploading 5 files (one file is of type image, and others of type PDF), and the user has passed the option to accept/allow only image type files, will the server reject all the other types of files and not upload it?

[salahlalami]

@Aman-Gupta-404
1- option is pre-defin config accessible only from the backend , default is single , typeFile is image by deafult, user can't decide . this is generic upload , we will use in different route

2- same this is should have some default , and other is option config is accessible only from the backend , user can't change it

there is no request params or from request body

[Aman-Gupta-404]

okay, i'll start working on it

[Aman-Gupta-404]

Hi @salahlalami

1. I added the option to add multiple files [set the limit to 100 though, for safety purposes]

updated the all the functions in uploadMiddleware.js file to save multiple files to the database at once (used insertMany function of mongoose)

2. Added the feature to check the type of file type before accepting it in the backend, and this can be changed

Here I added a filter function for multer called fileFilter to filter/check and accept only specific files only.
Here we can update _fileType array within fileFilter function present int the uploadMiddleware.js in the future to upload certain types of files only.

Do check it, and let me know if there are any issues

[salahlalami]

Thank you @Aman-Gupta-404 ,
1- revert app.js
2- revert erpApi.js
3- remove yarn lock from your commit

could you record video to see how it work

[Aman-Gupta-404]

Hey @salahlalami, I have resolved the conflicts and tested the code, it works fine after reverting the changes

I have also recorded the video to show how it works:

See the video by clicking here

do let me know if there are any other issues

[salahlalami]

Thank you @Aman-Gupta-404 , we will merge it soon