New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Docs to Vercel #652
Move Docs to Vercel #652
Conversation
Thanks @mcsdevv!! This is huge, testing it out now I'll see if I notice anything funny with the routing. |
Okay things look close but I'm seeing a few issues:
Any insight you have on these issues is appreciated. |
Hey @mathisonian, I've got some ideas and will take a look tomorrow 👍 |
Sounds good - thanks @mcsdevv! |
@mathisonian a couple of questions, I'm not overly familiar with this version of Next.js so please excuse:
|
@mcsdevv I think it is safe to ignore / remove that With respect to save functionality in development, yes I would expect that to work (it does currently if you run the version on master). The saving functionality is handled via another app which exposes API so there isn't much logic in these docs other than sending a request, waiting for a response, and redirecting to the correct spot based on the response. |
Hey @mathisonian, thanks for confirming. I'm struggling to find the time to finish this right now, I think it's all good barring the save functionality. I'll try and get to it next week. |
Thanks @mcsdevv! |
Hey @mcsdevv, any chance you think you'll have some time to look at this this week before Vercel cuts of the 1.0 deployments? |
I'm going to merge this now, because partially broken docs are better than deleted docs :/ We'll have to fix the rest later! |
Hey @mathisonian, sorry I've been a little busy lately, I'll ask a member of the team to take a look though! |
Thanks @mcsdevv! Really appreciate you getting us this far |
This PR gets rid of
server.js
androutes.js
in favor of Next.jsredirects
.It also makes use of the
Router
andLink
components provided by Next.js.There may be some behavior with the routing that has been changed and requires amending. If so, please let me know in the comments here and we can do so.
Edit: definitely scope for another PR upgrading Next.js and making the docs fully static!