Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonize active power sanity check #135

Open
t-ober opened this issue Feb 10, 2022 · 0 comments · May be fixed by #138
Open

Harmonize active power sanity check #135

t-ober opened this issue Feb 10, 2022 · 0 comments · May be fixed by #138
Assignees
@t-ober
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@t-ober
Copy link
Contributor

t-ober commented Feb 10, 2022 •
edited

Both WecInput and PvInput compare their active power output against the maximum permissible power. Even if the calculated power output exceeds the maximum power it returns the maximum power whereas the wec model never outputs more than the maximum permissible power.

The latter one seems the way to go so harmonize the approach.
@t-ober t-ober added the enhancement New feature or request label Feb 10, 2022
@t-ober t-ober added this to the Version 3.0 milestone Feb 10, 2022
@t-ober t-ober self-assigned this Feb 10, 2022
@t-ober t-ober changed the title Provide uuid for failed sanity check within PVModel Fix sanity check and provide uuid for failed sanity check within PVModel Feb 10, 2022
@t-ober t-ober changed the title Fix sanity check and provide uuid for failed sanity check within PVModel Harmonize active power sanity check Feb 10, 2022
@t-ober t-ober linked a pull request Feb 11, 2022 that will close this issue
Draft
@sebastian-peter sebastian-peter mentioned this issue Aug 18, 2022
Open
@sebastian-peter sebastian-peter added the good first issue Good for newcomers label Feb 17, 2023
@sebastian-peter sebastian-peter removed this from the Version 3.0 milestone Feb 17, 2023
@dependabot dependabot bot mentioned this issue Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-ober t-ober

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

To/#135 harmonize active power output ie3-institute/simona
2 participants
@sebastian-peter @t-ober