Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specificEntropy of Media.Air may be incorrect #193

Closed
mwetter opened this issue Mar 21, 2015 · 0 comments · Fixed by #195
Closed

specificEntropy of Media.Air may be incorrect #193

mwetter opened this issue Mar 21, 2015 · 0 comments · Fixed by #195
Assignees
Labels

Comments

@mwetter
Copy link
Contributor

mwetter commented Mar 21, 2015

This is implemented as

redeclare function extends specificEntropy
"Return the specific entropy, only valid for phi<1"
protected
Modelica.SIunits.MoleFraction[2] Y "Molar fraction";
algorithm
Y := massToMoleFractions(
state.X, {steam.MM,dryair.MM});
s := specificHeatCapacityCp(state) * Modelica.Math.log(state.T/reference_T)
- Modelica.Constants.R *
sum(state.X[i]/MMX[i]*
Modelica.Math.log(max(Y[i], Modelica.Constants.eps)) for i in 1:2);

It appears that the last term should be multiplied by p/reference_p.
See also the implementation in Modelica.Media.Air.MoistAir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant