Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify implementation of derivatives #303

Closed
8 tasks done
mwetter opened this issue Aug 6, 2015 · 0 comments · Fixed by #307
Closed
8 tasks done

Verify implementation of derivatives #303

mwetter opened this issue Aug 6, 2015 · 0 comments · Fixed by #307

Comments

@mwetter
Copy link
Contributor

mwetter commented Aug 6, 2015

  • The following examples need to be revised so that the derivative of the function argument is different from 1. This is needed to verify the correct implementation of the implementation of the derivative function:
    • Media.Examples.AirDerivativeCheck
    • Media.Examples.WaterDerivativeCheck
    • Media.Specialized.Air.Examples.PerfectGasDerivativeCheck
    • Media.Specialized.Water.Examples.TemperatureDependendentDerivativeCheck
  • The functions in the package Utilities.Math.Functions.BaseClasses do not multiply the return value with the derivative of the argument. This need to be corrected and the regression tests need to be updated to catch this error.
  • The package Utilities.Psychrometrics.Functions.BaseClasses also need to be verified.
  • The function
    Media.Specialized.Water.TemperatureDependentDensity.density_derT_p
    declares smooth() and smoothOrder which causes Dymola (and likely other tools too) to assume it is twice differentiable rather than once.
mwetter added a commit that referenced this issue Aug 17, 2015
@mwetter
Revised unit tests for derivatives.
2a9a104 
For #303
mwetter added a commit that referenced this issue Aug 18, 2015
@mwetter
Removed dublicate entry of <code>smooth<code> and <code>smoothOrder</…
2386428 
…code>.

For #303
mwetter added a commit that referenced this issue Aug 18, 2015
@mwetter
Updated regression tests to verify implementation of derivatives.
a04c4d5 
For #303.
The previous implementations did not properly check the implementation
if the rate of change is different from one.
mwetter added a commit that referenced this issue Aug 18, 2015
@mwetter
Corrected wrong derivative implementation for #303.
be76567
mwetter added a commit that referenced this issue Aug 19, 2015
@mwetter
Revised derivative implementation for #303
ae48308
@mwetter mwetter mentioned this issue Aug 19, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue303 derivatives ibpsa/modelica-ibpsa
1 participant
@mwetter