Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing port_a_exposesState and port_b_exposesState #351

Closed
mwetter opened this issue Nov 13, 2015 · 6 comments
Closed

Consider removing port_a_exposesState and port_b_exposesState #351

mwetter opened this issue Nov 13, 2015 · 6 comments
Assignees

Comments

@mwetter
Copy link
Contributor

mwetter commented Nov 13, 2015

Consider removing in PartialTwoPort the parameters
port_a_exposesState and port_b_exposesState.
I don't think any library is using this feature.

@mwetter
Copy link
Contributor Author

mwetter commented Nov 13, 2015

I suggest to remove these parameters as they cannot be dynamically changed on the diagram layer. For example, change in Movers.BaseClasses.PartialFlowMachine the extends statement to be

extends Buildings.Fluid.Interfaces.PartialTwoPortInterface(show_T=false,
    port_a_exposesState=energyDynamics <> Modelica.Fluid.Types.Dynamics.SteadyState,

Looking at Movers.Validation.PumpCurveConstruction shows that the icon still shows the graphical annotation despite that the pumps are configured to be steady-state.

I therefore suggest to remove these parameters. What is the position of Aachen, UdK and Leuven?

@mlauster
Copy link
Member

From Aachen side, we are using this, but I'm not sure yet if it works in our cases. We need to check this.

@mlauster
Copy link
Member

Aachen should be fine with removing this.

@Mathadon
Copy link
Member

Ok, we never use it!

@carlesRT
Copy link
Contributor

I think we also do not use it.

@mwetter mwetter self-assigned this Nov 19, 2015
mwetter added a commit that referenced this issue Nov 19, 2015
Mathadon added a commit that referenced this issue Dec 1, 2015
@Mathadon
Copy link
Member

Mathadon commented Dec 5, 2015

This seems to be merged.

@Mathadon Mathadon closed this as completed Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants