-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MixingVolumeZeroFlow tests for accuracy of 1E-60 #441
Comments
I guess this is similar to #439 where the algebraic system solver is also unable to find the exact solution of the algebraic loop. It makes sense that 1E-60 is then too small since the accuracy of the algebraic loop solver (in Dymola) seems +- half the machine accuracy, resulting in errors of ~1e-7. Are these also the kinds of values you get? |
@Mathadon To be able to also simulate these tests with other tools than Dymola, we should relax the assert to have an accuracy that is one -- or probably better two -- orders of magnitude less than the solver tolerance. |
We do also see the same problem when simulated with JModelica. |
The model
Annex60.Fluid.MixingVolumes.Validation.MixingVolumeZeroFlow
fails to simulate in OpenModelica because the assertsare too strict. The message is
This test needs to be less strict to allow for rounding errors or numerical approximation to solutions (assuming that there is no closed solution, which I did not verify).
The text was updated successfully, but these errors were encountered: