Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asserts for Q_flow in MixingVolume when m_flow=0 #470

Closed
Mathadon opened this issue May 11, 2016 · 0 comments · Fixed by #555
Closed

Asserts for Q_flow in MixingVolume when m_flow=0 #470

Mathadon opened this issue May 11, 2016 · 0 comments · Fixed by #555

Comments

@Mathadon
Copy link
Member

Mathadon commented May 11, 2016

We should add an assert that verifies if energy is conserved for zero flow if the mixing volume is configured to be steady-state energy balance.
This may detect certain singularities instead of throwing an error in the algebraic loop solver, which may result in the problems discussed in #445 .

The assert should check if the heat flow rate is such that the corresponding temperature increase stays below a certain bound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant