Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - water with temperature-dependent density #487

Closed
carlesRT opened this issue Jul 5, 2016 · 1 comment · Fixed by #493
Closed

Documentation - water with temperature-dependent density #487

carlesRT opened this issue Jul 5, 2016 · 1 comment · Fixed by #493

Comments

@carlesRT
Copy link
Contributor

carlesRT commented Jul 5, 2016

I think section Limitations Specific heat capacity, thermal conductivity and viscosity are constant. Water is modeled as an incompressible liquid. There are no phase changes. is wrong.

Dynamic Viscosity is defined with
eta := density(state)*kinematicViscosity(state.T);

and the kinematic Viscosity with
if T < 278.15 then -(4.63023776563e-08)_T + 1.44011135763e-05
else
1.0e-6_Modelica.Math.exp(
-(7.22111000000000e-7)_T^3 + 0.000809102858950000_T^2
- 0.312920238272193*T + 40.4003044106506));

It was probably copied from Media.Water. In case I did not missunderstood the code I would be good to correct the docu and add a plot (viscosity against T)

@mwetter
Copy link
Contributor

mwetter commented Jul 5, 2016

@carlesRT
You are right about the error in the documentation. It would be great if you can make a pull request against the branch issue487_waterDocumentation

carlesRT added a commit to carlesRT/modelica-annex60 that referenced this issue Jul 6, 2016
carlesRT added a commit to carlesRT/modelica-annex60 that referenced this issue Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants