Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default value for heads and massFlowRates in Movers.FlowControlled_{dp, m_flow} #583

Closed
mwetter opened this issue Nov 10, 2016 · 0 comments · Fixed by #587
Closed

default value for heads and massFlowRates in Movers.FlowControlled_{dp, m_flow} #583

mwetter opened this issue Nov 10, 2016 · 0 comments · Fixed by #587
Assignees

Comments

@mwetter
Copy link
Contributor

mwetter commented Nov 10, 2016

The model Fluid/Movers/FlowControlled_m_flow.mo implements

parameter Modelica.SIunits.MassFlowRate[:] massFlowRates = m_flow_nominal*{0}

and Fluid/Movers/FlowControlled_dp.mo implements

parameter Modelica.SIunits.PressureDifference[:] heads(
     each min=0,
     each displayUnit="Pa") = dp_nominal*{1}

If a user instantiates a model FlowControlled_m_flow without overwriting the default, the pump/fan will never run. Also, if the pump/fan is used with peformance data that define multiple speeds, then the number of speeds is different from the number of stages, which is inconsistent.

I therefore suggest to set as the default, based on affinity laws,

  parameter Modelica.SIunits.MassFlowRate[:] massFlowRates=
    m_flow_nominal*{speeds[i]/speeds[end] for i in 1:size(per.speeds, 1)}

and

  parameter Modelica.SIunits.PressureDifference[:] heads(
    each min=0,
    each displayUnit="Pa")=
    dp_nominal*{(speeds[i]/speeds[end])^2 for i in 1:size(per.speeds, 1)}
@mwetter mwetter self-assigned this Nov 10, 2016
mwetter added a commit that referenced this issue Nov 10, 2016
mwetter added a commit that referenced this issue Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant