Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URL search query for pages and filter #67

Open
sahilatahar opened this issue May 5, 2024 · 9 comments
Open

Use URL search query for pages and filter #67

sahilatahar opened this issue May 5, 2024 · 9 comments

Comments

@sahilatahar
Copy link

What's the problem

Hi, I just found that when we navigate to specific page number but when we refresh or reload page we have to navigate to that page again.

video.mp4

What should be

You should use URL parameters pages

For example: https://goodfirstissues.com?lang=javasript&page=10

By using this method users filter and page no will not lost on refresh and link can be share with other user

Why it is bad practice

https://www.youtube.com/watch?v=oZZEI23Ri6E

@Babuprasanth27
Copy link

Hey, Shall I fix this issue?

@shivansh84ya
Copy link

Hey @sahilatahar,
Could you please assign this issue to me??

@Babuprasanth27
Copy link

@shivansh84ya hey brother, I just commented 2week before but still no reply from him.

@shivansh84ya
Copy link

I saw your comment. Did you start solving this issue?

@Babuprasanth27
Copy link

No he not assigned to me.

@shivansh84ya
Copy link

okay, @Babuprasanth27

@Babuprasanth27
Copy link

@shivansh84ya Shall we participate in hackathons?

@shivansh84ya
Copy link

yeah sure

@abhedanil
Copy link

Hi could you please assign it to me , so that i can start work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants