Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test script DRY #65

Closed
Weber-H2O2 opened this issue Aug 3, 2021 · 1 comment
Closed

Make test script DRY #65

Weber-H2O2 opened this issue Aug 3, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Weber-H2O2
Copy link
Member

test_encdes.sh, which is full of redundance code, is not DRY (Don't Repeat Yourself!). Please make it better in order to adding new test cases easily in the future:

  1. Write a function to encapsulate the check method
  2. Use random data to test, it will be better to use random data to test such operators
@Weber-H2O2 Weber-H2O2 mentioned this issue Aug 3, 2021
Closed
@Weber-H2O2 Weber-H2O2 added the enhancement New feature or request label Aug 3, 2021
@Weber-H2O2
Copy link
Member Author

The file does not exist now, hence the issue should be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Weber-H2O2