make size selection not scrict

[rom1504]

No description provided.

[iejMac]

is this for allowing lower resolution and sizing up?

[rom1504]

Yes

…

On Sun, Nov 20, 2022, 04:34 Maciej Kilian ***@***.***> wrote: is this for allowing lower resolution and sizing up? — Reply to this email directly, view it on GitHub <#40 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR437SSIT4ACSCJBM66LIDWJGL35ANCNFSM6AAAAAASFTZ7CI> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[iejMac]

@rom1504 couldn't find any way of specifying "closest format according to resolution" but we could manually do it in python by finding:

• worst format >= target_resolution
• best format <= target_resolution
  and comparing which is closer using metadata in the return formats

problem with this is not sure if we want to take on the extra overhead of playing with formats again. The speedup we recently got was from not playing with formats and just trusting yt-dlp to give us the best format. To that end I suggest 2 options, would like to hear some thoughts:

1. we try the thing I suggested earlier, test it, etc.
2. we implement resolution subsampler and use that on the output of data reader to get exact resolution we want and move this to v1

[iejMac]

ChatGPT suggests using max_resolution with height and width and then combine with | best

[iejMac]

summarizing my thoughts on this again:

we need to make it so that users have more choices about the output dimensionality than just - what YT has or EXACT video_size x video_size. To do this we need to implement the following functionality:

• try to pick the smallest video larger than the video_size
• if that's not available and all videos are smaller than take the largest video, smaller than video_size
• if some resize mode is "pad", pad the video to video_size x video_size
• otherwise just save the smaller version