fix memory leak in XKeyboard::build_layout #30
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XkbRF_VarDefsRec seems to be intended to be used only through XkbRF_RulesRec.
It includes dynamically allocated C string, but provides no direct
cleanup method. This commit adds custom cleanup as a workaround.
A proper cleanup would complicate the code even more, so this is just a bandaid to avoid the leak while keeping the code relatively compact.
XkbRF_VarDefsRec: https://github.com/freedesktop/xorg-libxkbfile/blob/master/include/X11/extensions/XKBrules.h
cleanup in khurshid-alam/Unity-Settings-Daemon: https://github.com/khurshid-alam/Unity-Settings-Daemon/blob/7135a08b39e17401338232ee3f0309582dd31202/plugins/keyboard/gsd-xkb-utils.c#L78