Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoRIM needs to support counter signatures #163

Open
yogeshbdeshpande opened this issue Oct 4, 2023 · 2 comments
Open

CoRIM needs to support counter signatures #163

yogeshbdeshpande opened this issue Oct 4, 2023 · 2 comments
Labels
enhancement New feature or request preferable first release Desirable to accommodate in initial release

Comments

@yogeshbdeshpande
Copy link
Collaborator

The base CoRIM specification refers to signer and signer details via signer-map.

However use cases coming from real world indicates that CoRIM should support multiple signers.

One such use case is the case of counter signatures, especially when CoRIM is blessed by a trusted auditor.

Specification should be enhanced to add the required text highlighting multiple signature support + CDDL needs to be revisited for any changes to support this enhancement

@yogeshbdeshpande yogeshbdeshpande added the enhancement New feature or request label Oct 4, 2023
@nedmsmith
Copy link
Collaborator

is it more complex than adding support for COSE_Sign?
e.g.:

signed-corim = #6.18(COSE-Sign1-corim)

becomes:

signed-corim = #6.18(COSE-Sign1-corim) / #6.19(COSE_Countersignature)

@thomas-fossati
Copy link
Collaborator

thomas-fossati commented Oct 4, 2023

I am not sure there's anything to do here: RFC9338 countersignatures can already be added to the COSE_Sign1 message that wraps the CoRIM tag

@yogeshbdeshpande yogeshbdeshpande added the preferable first release Desirable to accommodate in initial release label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preferable first release Desirable to accommodate in initial release
Projects
None yet
Development

No branches or pull requests

3 participants