Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ev-coswid-triple-record undefined in CoRIM draft? #190

Open
deeglaze opened this issue Jan 5, 2024 · 2 comments
Open

ev-coswid-triple-record undefined in CoRIM draft? #190

deeglaze opened this issue Jan 5, 2024 · 2 comments
Labels
For-next-release WIll only be addressed after first publish of CoRIM

Comments

@deeglaze
Copy link
Collaborator

deeglaze commented Jan 5, 2024

The accepted claims set type description uses the variable ev-coswid-triple-record without definition. I noticed this is also used in the Intel Profile for CoRIM, but there it references the TCG specification for concise evidence for DICE (https://trustedcomputinggroup.org/wp-content/uploads/TCG-DICE-Concise-Evidence-Binding-for-SPDM-Version-1.0-Revision-53_1August2023.pdf). Given the specificity to DICE, this seems overly specific for the CoRIM specification given that evidence is expected to be profile-specific, so I wonder what this hanging reference is meant to mean.

@nedmsmith
Copy link
Collaborator

accepted-claims-set technically is mythical as it intends to describe the Verifier's "internal representation" which is out of scope for this specification. We discussed whether or not using CDDL to describe an internal representation would be confusing. We also defined abstract terminology for the verifier in section 5.1 which is used to describe an "internal representation".

There are times when the prose needs to be specific about certain compare operations where having accepted-claims-set CDDL is a helpful abstraction. Other prose seems appropriate for more conceptual explanations.

I'm not convinced the accepted-claims-set CDDL is entirely correct, I think we're in a mode of working through use cases and identifying gaps in accepted-claims-set.

One challenge with using the same CDDL as is used to describe Verifier inputs, to describe Verifier outputs (or nearly Verifier outputs) is it assumes the Verifier's other inputs such as Appraisal Policy for Evidence and RP context isn't additive.

Specifically, the case of coswid, the coswid tags are additional inputs beyond the core comid schema. As such, you might expect these inputs should affect Verifier output. ev-coswid-triple-record is an example. Nevertheless, it models a Verifier output using an Evidence schema input.

Since it is a non-goal of CoRIM to define an Attestation Result format, it seems using CDDL to define accepted-claims-set implies an alternative to other drafts that do this. Technically, it isn't part of the CoRIM schema.

If there is a way to document the "internal representation" with as much precision as CDDL, but without using CDDL (or something similar) then that would be interesting prose to read.

@nedmsmith
Copy link
Collaborator

The TCG has published [https://trustedcomputinggroup.org/wp-content/uploads/TCG-DICE-Concise-Evidence-Binding-for-SPDM-Version-1.0-Revision-54_pub.pdf] which is the most recent publication of concise-evidence. The CoRIM spec, Section 5.5, contains subsections that describe mapping of evidence formats to an internal representation (aka ACS). Possibly, it makes sense to include a sub-section for concise-evidence that details the mapping semantics?

@yogeshbdeshpande yogeshbdeshpande added the For-next-release WIll only be addressed after first publish of CoRIM label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For-next-release WIll only be addressed after first publish of CoRIM
Projects
None yet
Development

No branches or pull requests

3 participants