Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measurement-map misnomer? (measurement/claim/assertion/property/proposition...?) #225

Open
deeglaze opened this issue Apr 7, 2024 · 3 comments
Labels
mustfix This is essential requirement for CoRIM Publish

Comments

@deeglaze
Copy link
Collaborator

deeglaze commented Apr 7, 2024

The measurement-map type is used for non-measurement claims, such as attesting environment topology and endorsements. Shall we rename measurement-map to claims-map, and measurement-values-map to claim-values-map ?

@yogeshbdeshpande yogeshbdeshpande added the mustfix This is essential requirement for CoRIM Publish label May 7, 2024
@deeglaze deeglaze changed the title measurement-map misnomer? measurement-map misnomer? (measurement/claim/assertion/property/proposition...?) Jun 5, 2024
@deeglaze
Copy link
Collaborator Author

deeglaze commented Jun 5, 2024

Let's determine in this issue which term we want to use for the logical propositions that are used by endorsements, reference values, and abstract verifier state.

@deeglaze
Copy link
Collaborator Author

deeglaze commented Jun 5, 2024

To recap the discussion,

  • "Measurement" is not particularly helpful given that endorsements can be about unmeasured properties, such as a certifying body's assignment of a "security level".
  • "Claim" is not appropriate because while analogous to the JWT/CWT term, the general definition of key/value pair is in fact too general.
  • "Assertion" is a candidate. It has precedent in the Asylo attestation terminology of assertions and their dual, conditions. It does have the unfortunate connotation of a program-crashing check.
  • "Statement" is a candidate, but doesn't carry the logical connotation we want to convey.
  • "Proposition" is a candidate, but might have too absolute of a connotation.
  • "Property" is a candidate, but is overloaded with the JavaScript notion of "property". The distance from CoRIM->CWT->JWT->JavaScript might be too short to keep the terms from being too confusing during discussion.

However way we slice it there will be tradeoffs. I think the least offensive to folks' sensibilities given text proposed by everyone at some point is "Assertion". Let's make a final decision though.

@thomas-fossati
Copy link
Collaborator

I wouldn't rule out Claims: I see its generality as a feature rather than a bug. This would still be my preference.

Among the other proposals, I can live with Property or Assertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mustfix This is essential requirement for CoRIM Publish
Projects
None yet
Development

No branches or pull requests

3 participants