Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo issues with -01 #20

Closed
gmandyam opened this issue Jul 21, 2019 · 2 comments
Closed

Typo issues with -01 #20

gmandyam opened this issue Jul 21, 2019 · 2 comments

Comments

@gmandyam
Copy link
Collaborator

gmandyam commented Jul 21, 2019

They can be addressed in a -02 version.

Sec. 3: Change ""It also mentions several claims defined by CWT and JWT are particularly important for EAT." to 'that are particularly important'

Sec. 3: Correct "* All claims are optional * No claims are mandatory *." Redundant.

Sec. 3.11: "Typically, one will be the device-wide EAT that is low to medium security and another from a Secure Element or similar that is high security.” Consider changing "Typically" to "For example".

Sec. 3.11: "The contents of the "eat" claim must be a fully signed, ...". "eat" claim should be "nested_eat" claim.

@laurencelundblade
Copy link
Collaborator

I fixed the last two and pushed to GitHub.

I like the first two the way they are.

@laurencelundblade
Copy link
Collaborator

Update: fixe the first one now that I see the missing "that".

Have created a separate issue for claim optionality: #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants