Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should expose breaking changes to source data structure #284

Open
rjsparks opened this issue Aug 31, 2022 · 1 comment
Open

Tests should expose breaking changes to source data structure #284

rjsparks opened this issue Aug 31, 2022 · 1 comment

Comments

@rjsparks
Copy link
Member

There are several places where the bibxml code is having to adjust to changes in the relaton source data, and tests didn't show that things had become disconnected.

This needs to be addressed in addition to whatever actions come from the conversations around versioning libraries to help avoid encountering breaking changes by surprise in the future.

References:
#282 (review)
#283

@strogonoff
Copy link
Collaborator

strogonoff commented Sep 1, 2022

As discussed with Kesara today, I don’t think the correctness of this Django project codebase should depend on the correctness of data sources and don’t want this project’s tests to also indirectly test Ruby gems (as well as network connectivity to Github repositories, etc.). We’ll look into making separate integration test scripts, like test_paths.py which was created for this purpose, run on GHA CI periodically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants