Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

previous_announcement.cgi #23

Closed
ietf-svn-bot opened this issue Apr 28, 2007 · 15 comments
Closed

previous_announcement.cgi #23

ietf-svn-bot opened this issue Apr 28, 2007 · 15 comments

Comments

@ietf-svn-bot
Copy link

owner:michael.lee@neustar.biz resolution_fixed type_task | by henrik@levkowetz.com



Issue migrated from trac:23 at 2022-03-04 00:31:19 +0000

@ietf-svn-bot
Copy link
Author

@michael.lee@neustar.biz changed status from new to assigned

@ietf-svn-bot
Copy link
Author

@michael.lee@neustar.biz changed owner from `` to michael.lee@neustar.biz

@ietf-svn-bot
Copy link
Author

@fenner@research.att.com commented


I thought that (while it's a change of user interface) it might be more appropriate to use date-based generic views for both previous_announcement.cgi and recent_announcement.cgi.

That's a tradeoff between our plan to "not change look and feel" vs. using new features that django enables.

@ietf-svn-bot
Copy link
Author

@michael.lee@neustar.biz changed status from assigned to closed

@ietf-svn-bot
Copy link
Author

@michael.lee@neustar.biz changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@fenner@research.att.com commented


This got lost in the trac failure:

two things that need to happen in the view and template:

  • (in the view) if there is no ballot id, then check for the presence of a (historical) file

  • (in the template) if there is no ballot id, then link to the file. if there is no file, then don't link.

@ietf-svn-bot
Copy link
Author

@fenner@research.att.com changed status from closed to reopened

@ietf-svn-bot
Copy link
Author

@fenner@research.att.com changed resolution from fixed to ``

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented May 30, 2007

@michael.lee@neustar.biz commented


Replying to ietf-svn-conversion/datatracker#23 (comment:4):
Just found out that the Secretariat (Foretec era) had been storing some old announcement messages since October 1998. Therefore, the tool should list announcments from October 1998.

Inline.

This got lost in the trac failure:

two things that need to happen in the view and template:

  • (in the view) if there is no ballot id, then check for the presence of a (historical) file
    Why would view.py need to check for the presence of a historical file while the template is doing same checking as stated below?

  • (in the template) if there is no ballot id, then link to the file. if there is no file, then don't link.
    I did some quick research on how a template can check a file system, but no luck yet.
    Does any body know how a template can read the file system?

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented May 30, 2007

@michael.lee@neustar.biz commented


Replying to ietf-svn-conversion/datatracker#23 (comment:6):

BTW, the perl script is only displaying the items with ballot_id, not filed ones.

Michael.

Replying to ietf-svn-conversion/datatracker#23 (comment:4):
Just found out that the Secretariat (Foretec era) had been storing some old announcement messages since October 1998. Therefore, the tool should list announcments from October 1998.

Inline.

This got lost in the trac failure:

two things that need to happen in the view and template:

  • (in the view) if there is no ballot id, then check for the presence of a (historical) file
    Why would view.py need to check for the presence of a historical file while the template is doing same checking as stated below?

  • (in the template) if there is no ballot id, then link to the file. if there is no file, then don't link.
    I did some quick research on how a template can check a file system, but no luck yet.
    Does any body know how a template can read the file system?

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented May 30, 2007

@fenner@research.att.com commented


Replying to ietf-svn-conversion/datatracker#23 (comment:6):

Replying to ietf-svn-conversion/datatracker#23 (comment:4):

two things that need to happen in the view and template:

  • (in the view) if there is no ballot id, then check for the presence of a (historical) file
    Why would view.py need to check for the presence of a historical file while the template is doing same checking as stated below?

The view does the checking, since the template can't, and stores the info in the objects getting passed to the template.

  • (in the template) if there is no ballot id, then link to the file. if there is no file, then don't link.
    I did some quick research on how a template can check a file system, but no luck yet.
    Does any body know how a template can read the file system?

The view should check the filesystem, and the template should look at the results of that check.

@ietf-svn-bot
Copy link
Author

@michael.lee@neustar.biz changed status from reopened to closed

@ietf-svn-bot
Copy link
Author

@michael.lee@neustar.biz changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

removed milestone (was IESGAnnouncements)

@ietf-svn-bot
Copy link
Author

commented


Milestone IESGAnnouncements deleted

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant