Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to drop dependency on decorator package #5654

Open
1 task done
jennifer-richards opened this issue May 18, 2023 · 1 comment · Fixed by #7199
Open
1 task done

Refactor to drop dependency on decorator package #5654

jennifer-richards opened this issue May 18, 2023 · 1 comment · Fixed by #7199
Assignees
Labels
accepted contrib-easy Easy dev difficulty for contribution enhancement New feature or request medium

Comments

@jennifer-richards
Copy link
Member

Description

We have a few decorators defined in ietf/utils/decorator.py that use the "decorator" package. This provides the @decorator decorator and a decorate method. The built-in Python functools.wraps() method can fulfill the needs here without the additional dependency. As far as I can tell we're not making use of any of the features provided by the "decorator" package.

The @decorator mechanism also seems to interfere with Django's @method_decorator, which led to refactoring the requires_api_key decorator already.

Code of Conduct

@jennifer-richards jennifer-richards added enhancement New feature or request minor labels May 18, 2023
@rjsparks rjsparks added the contrib-easy Easy dev difficulty for contribution label Jul 12, 2023
@microamp microamp self-assigned this Mar 16, 2024
@jennifer-richards
Copy link
Member Author

Reopening - there is still a dependency in debug.py as @microamp mentioned in his PR comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted contrib-easy Easy dev difficulty for contribution enhancement New feature or request medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants