Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the "Mailing list discussion" link for rfcs is incorrect #6823

Closed
rjsparks opened this issue Dec 20, 2023 · 7 comments · Fixed by #6835
Closed

the "Mailing list discussion" link for rfcs is incorrect #6823

rjsparks opened this issue Dec 20, 2023 · 7 comments · Fixed by #6835

Comments

@rjsparks
Copy link
Member

The generated link into the mailarchive uses &q= where it should use /q=. The query should also look for both references to the rfc name and the name of the draft the rfc came from.

@elear
Copy link
Collaborator

elear commented Dec 20, 2023

Just a comment of no particular significance. I realize it's your namespace, but is that meant to be a query, but yet doesn't quite look like one? Would it make sense to add &q= into the mailarchive?

@jennifer-richards
Copy link
Member

I think it's currently generating .../?email_list=<acro>?q=<docname> but should be.../?email_list=<acro>&q=<docname>

@jennifer-richards
Copy link
Member

(i.e., what @elear asks for seems to be supported by mailarchive)

@rjsparks
Copy link
Member Author

This is a data cleaning / code robustness issue:

<a href="{{ doc.group.list_archive }}?q={{ doc.name }}">

and

>>> Group.objects.filter(list_archive__endswith="/").count()
383
>>> Group.objects.exclude(list_archive="").exclude(list_archive__endswith="/").count()
334

@rjsparks
Copy link
Member Author

And I typo-ed in the original post, stimulating an unnecessary conversation - apologies.

@rjsparks
Copy link
Member Author

Yet redirects at mailarchive are handling those differences already. Attempting to rediscover the document that motivated this issue.

@rjsparks
Copy link
Member Author

Relocated - the issue is at /doc/rfc5280/ which links to https://mailarchive.ietf.org/arch/search/?email_list=pkix?q=rfc5280 because

>>> Group.objects.get(acronym='pkix').list_archive
'https://mailarchive.ietf.org/arch/search/?email_list=pkix'

Further:

>>> Group.objects.filter(list_archive__contains="?email_list").count()
165

We should transform those to use the shorter version of /arch/browse/<acronym>

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants