Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad dashboard shows drafts that have become RFCs both as drafts and as RFCs #6864

Closed
rjsparks opened this issue Jan 3, 2024 · 2 comments · Fixed by #6884
Closed

ad dashboard shows drafts that have become RFCs both as drafts and as RFCs #6864

rjsparks opened this issue Jan 3, 2024 · 2 comments · Fixed by #6884

Comments

@rjsparks
Copy link
Member

rjsparks commented Jan 3, 2024

See the sections labelled "RFCs" and "Published RFCs" - Only the second section should be kept.
At the moment, the sections don't have the same number of documents in them which is surprising. Develop and understanding of that while working on the issue.

Marking this major because it is causing Roman's dashboard to go over the search result size limit.

@rjsparks
Copy link
Member Author

rjsparks commented Jan 3, 2024

cc: @rdanyliw

@rjsparks
Copy link
Member Author

rjsparks commented Jan 4, 2024

This was two issues interacting to make confusing results.

  1. Filtering documents out of the interesting set of Documents with ad=this_ad happens after the queryset has been limited to a maximum number
  2. That filtering didn't remove drafts that had become RFCs (as it should post feat/rfc).

This is why there were both RFC Internet Drafts ({state} {type}s) and Published RFCs (again {state} {type}s) in the results, and why the number of such things were different. In Roman's case some of the RFC Internet Drafts were in the fetched set after the cutoff.

This is another example of where prepare_document_table and fill_in_document_table_attributes have become far to convoluted and need to be redesigned.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant