Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IETF Agenda: Link for chat logs missing trailing / #7260

Open
1 task done
moonshiner opened this issue Mar 26, 2024 · 4 comments
Open
1 task done

IETF Agenda: Link for chat logs missing trailing / #7260

moonshiner opened this issue Mar 26, 2024 · 4 comments

Comments

@moonshiner
Copy link

moonshiner commented Mar 26, 2024

Describe the issue

The IETF Meeting agenda page includes a link to the chat logs for a working group. For example, the current link generated is https://datatracker.ietf.org/meeting/119/materials/chatlog-119-dnsop-202403181530-00

However @rjsparks pointed out the correct link to use is this one:

https://datatracker.ietf.org/doc/chatlog-119-dnsop-202403181530/00/

Code of Conduct

@richsalz
Copy link
Collaborator

Is the fix just to add a trailing slash at https://github.com/ietf-tools/datatracker/blob/main/ietf/settings.py#L1010 ?

@rjsparks
Copy link
Member

Is the fix just to add a trailing slash at https://github.com/ietf-tools/datatracker/blob/main/ietf/settings.py#L1010 ?

No - that's an unrelated link back to zulip, not to the captured chat log documents for the proceedings.

And this issue is more involved than adding a trailing slash somewhere - it involves whether to point to the raw document or the info page for the document (that renders the document in a nicer format).

@moonshiner
Copy link
Author

I realized this after the fact the links are more different than my cursory glance gave it.

If I may vote, I like the info, nicer formatted page.

@pselkirk
Copy link
Collaborator

pselkirk commented Mar 26, 2024

FWIW, although the proceedings and agenda views only link to the document file, the session view (/meeting/119/session/dnsop) links to the document info page as well:

<a href="https://datatracker.ietf.org/meeting/119/materials/chatlog-119-dnsop-202403181530-00">Chat Log IETF119: dnsop: Mon 15:30</a>
<a href="/doc/chatlog-119-dnsop-202403181530/">(chatlog-119-dnsop-202403181530)</a>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants