Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

figure cut off in PDF rendering #787

Closed
alicerusso opened this issue May 31, 2022 · 0 comments · Fixed by #788
Closed

figure cut off in PDF rendering #787

alicerusso opened this issue May 31, 2022 · 0 comments · Fixed by #788
Assignees
@kesara
Labels
accepted critical pdf Issues in PDF output rfc waiting An RFC-to-be is in the "Tools Issue" state and cannot be published until the issue is resolved

Comments

@alicerusso
Copy link

alicerusso commented May 31, 2022 •
edited

In the PDF, the last 33 lines of Figure 3 are missing. (In XML, it's a figure element that contains one artwork element.) The page 50/51 break appears, and the rest of the figure is not there, then the figure title appears on p. 51.

Compare Figure 3 in the PDF vs. HTML of this document.
https://www.rfc-editor.org/v3test/rfc9260.pdf#figure-3
https://www.rfc-editor.org/v3test/rfc9260.html#figure-3
(source: https://www.rfc-editor.org/v3test/rfc9260.xml)

Haven't ever seen this issue before. (I tried prepping the XML first, and then rendering the PDF file; same issue.)

xml2rfc 3.12.8
WeasyPrint version 52.5
@kesara kesara added critical pdf Issues in PDF output labels Jun 1, 2022
@kesara kesara self-assigned this Jun 1, 2022
@kesara kesara added accepted rfc waiting An RFC-to-be is in the "Tools Issue" state and cannot be published until the issue is resolved labels Jun 1, 2022
@kesara kesara mentioned this issue Jun 2, 2022
Merged
@kesara kesara mentioned this issue Jul 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kesara kesara

Labels
accepted critical pdf Issues in PDF output rfc waiting An RFC-to-be is in the "Tools Issue" state and cannot be published until the issue is resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Display long ASCII art correctly in PDF kesara/xml2rfc
2 participants
@kesara @alicerusso