Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User reference as an assertion #51

Closed
jricher opened this issue Nov 13, 2020 · 3 comments · Fixed by #305
Closed

User reference as an assertion #51

jricher opened this issue Nov 13, 2020 · 3 comments · Fixed by #305
Assignees

Comments

@jricher
Copy link
Collaborator

jricher commented Nov 13, 2020

§2.4.1 Identifying the User by Reference: Editor's note:

We might be able to fold this function into an unstructured user assertion reference issued by the AS to the RC. We could put it in as an assertion type of "gnap_reference" or something like that. Downside: it's more verbose and potentially confusing to the client developer to have an assertion-like thing that's internal to the AS and not an assertion.

@fimbault
Copy link
Collaborator

fimbault commented Mar 1, 2021

Why an assertion? Is that reference supposed to be linked to a session (cf "represent the same end-user to the AS over subsequent requests") or can it be persistent?
I would see that more as an opaque identifier, rather than an assertion.

Something like:

"user": {
   "sub_ids": [ {
     "subject_type": "as_ref",
     "as_ref": "XUT2MFM1XBIKJKSDU8QM"
   } ]
}

as_ref seems a bit specific to GNAP (reference managed by the AS) but it could always be read "as a reference" in a more general setting. There's a variety of generic names that we could choose if needed, local_uid, internal_uid, etc.
But that really asks what additional types we could define as part of secevents (section 7.1.2).

Beyond the case mentioned here, it would be most useful as an opaque identifier when RO != end-user, to avoid leaking private info about the RO (although currently we don't seem to cover that case yet)

It's indeed more verbose than "user": "XUT2MFM1XBIKJKSDU8QM" but at least it's always the same structure (doesn't depend whether it's a reference or not), and it also makes the type more explicit.

@jricher
Copy link
Collaborator Author

jricher commented Mar 1, 2021

A subject identifier makes sense here, and I agree that it should be a new subject_type value to let us constrain it to the GNAP context.

@fimbault fimbault self-assigned this Mar 29, 2021
@fimbault
Copy link
Collaborator

Fixed by SECEVENT opaque identifiers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants