Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONNECT-UDP Stream Chunk extensibility #24

Closed
LPardue opened this issue Dec 14, 2020 · 2 comments
Closed

CONNECT-UDP Stream Chunk extensibility #24

LPardue opened this issue Dec 14, 2020 · 2 comments

Comments

@LPardue
Copy link

LPardue commented Dec 14, 2020

https://tools.ietf.org/html/draft-ietf-masque-connect-udp-01#section-5 defines Stream Chunk and follows up with a statement about extensibility

CONNECT-UDP Stream Chunk {
     CONNECT-UDP Stream Chunk Type (i) = 0x00,
     UDP Payload Length (i),
     UDP Payload (..),
   }

<snip/>

   The bidirectional stream that the CONNECT-UDP request was sent on is
   a sequence of CONNECT-UDP Stream Chunks.  The CONNECT-UDP Stream
   Chunk Type is designed to allow future extensibility.  Endpoints that
   receive a chunk with an unknown CONNECT-UDP Stream Chunk Type MUST
   silently skip over that chunk.

It isn't clear to me if the UDP Payload Length field belongs solely to type 0x00 or if its expected to be the chunk length and applicable to all Chunk Types that are known or unknown. If the chunk length in notcommon to all chunks, I don't see how an endpoint can silently skip unknown chunks.

@DavidSchinazi
Copy link
Collaborator

You're absolutely right, that text is not very well written. What I meant to say is that the type and length are generic and the value depends on the type - and if the type is 0x00 then the value is a UDP payload. I'll fix the text.

@DavidSchinazi
Copy link
Collaborator

I fixed the text in draft-ietf-masque-connect-udp-02, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants