Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP Assignment request #31

Closed
mirjak opened this issue May 17, 2021 · 3 comments · Fixed by #32
Closed

IP Assignment request #31

mirjak opened this issue May 17, 2021 · 3 comments · Fixed by #32

Comments

@mirjak
Copy link

mirjak commented May 17, 2021

The requirement on IP Assignment only specifies that the client or server can "request" an IP address (or range). However, for an VPN like use case it would be sufficient if the proxy just selects an address and tells the client. I think both cases should be covered in the requirement. This is proposed in PR #21

@DavidSchinazi
Copy link
Collaborator

Agreed, I've written up #32 to address this.

@mirjak
Copy link
Author

mirjak commented May 17, 2021

Thanks for creating this PR. I think it would also be nice, if an address was assigned, to signal this to the peer. Can we also cover this in this requirement?

@DavidSchinazi
Copy link
Collaborator

@mirjak good point, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants