Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider specifying problem type for "unrecognized aggregation job" #270

Closed
branlwyd opened this issue Jun 13, 2022 · 3 comments · Fixed by #285
Closed

Consider specifying problem type for "unrecognized aggregation job" #270

branlwyd opened this issue Jun 13, 2022 · 3 comments · Fixed by #285

Comments

@branlwyd
Copy link
Collaborator

Similarly to the "unrecognizedTask" error token, a request might reference a nonexistent/unknown aggregation job. It may be useful to specify an "unrecognizedAggregationJob" or similar error token for this case.

@cjpatton
Copy link
Collaborator

I noticed this as well. In fact, there are a few error cases we're not covering right now. I wonder if we really need to cover them all? In any case I am not opposed to adding this one.

@branlwyd
Copy link
Collaborator Author

I think we probably don't need to specify many errors; my thinking, at least, is that we only need to specify the error types that, when communicated, will cause a difference in behavior on the part of the receiver which is relevant to interoperability. (Certainly, implementations might choose to have more granular errors to e.g. ease debuggability, but this can be left implementation-specific.)

I'm not sure if that's the right bar to justify a new error code; it makes sense to me since it follows the principle of "specify minimal behavior to allow interoperability."

Perhaps we should eventually decide what justifies an error code being specified, and do a larger pass over the error codes to (de-)specify things that are not needed?

@branlwyd
Copy link
Collaborator Author

branlwyd commented Jul 5, 2022

(in any case, the general principle of what should/should not be an error condition is probably outside the scope of this issue. I'm happy enough trying to specify unrecognizedAggregationJob for now; if you'd like to specify any of the other error cases you mention, I can do so as well.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants