Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata definition #276

Closed
simon-friedberger opened this issue Jun 20, 2022 · 5 comments
Closed

Add metadata definition #276

simon-friedberger opened this issue Jun 20, 2022 · 5 comments

Comments

@simon-friedberger
Copy link
Contributor

It would be convenient for testing purposes if we could just collect some random data and also send that data as metadata for comparison.

Since we already discussed that we might need other metadata for slicing I think it would be good to add a definition for it. Could probably be as simple as saying "there are n opaque metadata bytes with n, it's meaning and usage defined by the task".

@chris-wood
Copy link
Collaborator

@simon-friedberger Hmm, I'm not following this issue. It sounds like implementations can just decide what sort of metadata they might include, if I understand what you mean by metadata, and throw it in an extension. Do you have a specific change to the spec in mind?

@cjpatton
Copy link
Collaborator

I agree with Chris W., it seems like the extensions field of the Report could be used for this purpose.

@tgeoghegan
Copy link
Collaborator

Also, if we're specifically talking about enabling correctness testing (i.e., verifying that the aggregates that come out of the pipeline match the real sums over the original inputs), then we've had luck with deterministically deriving inputs from a timestamp (or in the case of DAP, the report nonce), so that the collector can re-derive the inputs without any additional communication channel between protocol participants.

@chris-wood
Copy link
Collaborator

@simon-friedberger given the above, are we OK to close this issue, or do you think there are spec changes that need to happen?

@simon-friedberger
Copy link
Contributor Author

Seems good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants