Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responses to Gen-ART review comments #165

Merged
merged 1 commit into from Jul 8, 2019
Merged

Responses to Gen-ART review comments #165

merged 1 commit into from Jul 8, 2019

Conversation

bifurcation
Copy link
Contributor

No description provided.

@paulej
Copy link
Contributor

paulej commented Feb 7, 2019

LGTM

Copy link
Contributor

@fluffy fluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concern inline but rest looks good

source. The length of this field is 32 bits.
source. The length of this field is 32 bits. The SSRC value in the
EKT tag MUST be the same as the one in the header of the SRTP packet
to which the tag is appended.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change to must be the same. I don't see any security reasons it has to be the same and it removes the possibility of making sure keys arrive before media - I don't have any solid reasons we should not make this change but I worry there is something we are forgetting and I don't see any solid reason that we do need to make this change. Others have more thoughts on this one way or the other ?

Copy link
Contributor

@paulej paulej Feb 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last EKT draft in avtcore required that the SSRC in the EKT tag match the one in the packet header. I assume this is to prevent an attack where an entity can I transmit modified packets and cause endpoints to replace keys with keys of other senders. By keeping the SSRC matching requirement, it would mitigate attacks by those without the ability to otherwise alter the packet flow.

@bifurcation bifurcation merged commit 702fc56 into master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants