Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synced with ps2sdk, corrected some logic #188

Merged
merged 7 commits into from Feb 2, 2019
Merged

Synced with ps2sdk, corrected some logic #188

merged 7 commits into from Feb 2, 2019

Conversation

AKuHAK
Copy link
Member

@AKuHAK AKuHAK commented Jan 30, 2019

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

I just was trying to unify some things - and make them as it is in mainstream ps2sdk. I also fixed some errors which capture modern toolchain. there are still many things to do but at least for now opl can be compiled on modern gcc.

AKuHAK and others added 7 commits January 29, 2019 14:08
Synced with mainstream ps2sdk
This was made for making stuff compilable under modern toolchains
this error produced by modern toolchains.
Smap: synced with ps2de/ps2sdk@587cad4
Fixed error: lvalue required as left operand of assignment
Copy link
Contributor

@sp193 sp193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were back-ported from the PS2SDK and I see no problems with them.
Within these commits, some statements were changed to make GCC 4 and later happy, as some rules were changed, causing statements like these to be refused:

(unsigned int)ptr += count;

Although the logic was previously accepted and is working.

@ElPatas1 ElPatas1 merged commit 6eaf80b into ps2homebrew:master Feb 2, 2019
@ElPatas1
Copy link
Contributor

ElPatas1 commented Feb 2, 2019

@sp193, with this commit after update the PS2SDK no game works!
At least with the internal HDD all the games got a BSOD.

Best regards.

@AKuHAK
Copy link
Member Author

AKuHAK commented Feb 2, 2019 via email

@sp193
Copy link
Contributor

sp193 commented Feb 2, 2019

I think the problem is with UDNL. I didn't realize that the pointers were not pointers to bytes, so the new code is not very compatible with the original logic.
I'll issue a patch soon.

@AKuHAK AKuHAK deleted the patch-2 branch May 26, 2020 22:11
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
Synced with ps2sdk, corrected some logic
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
Synced with ps2sdk, corrected some logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants