New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synced with ps2sdk, corrected some logic #188
Conversation
Synced with mainstream ps2sdk
This was made for making stuff compilable under modern toolchains
this error produced by modern toolchains.
Please refer to this commit: ps2dev/ps2sdk@5a015a8
Smap: synced with ps2de/ps2sdk@587cad4
Fixed error: lvalue required as left operand of assignment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were back-ported from the PS2SDK and I see no problems with them.
Within these commits, some statements were changed to make GCC 4 and later happy, as some rules were changed, causing statements like these to be refused:
(unsigned int)ptr += count;
Although the logic was previously accepted and is working.
@sp193, with this commit after update the PS2SDK no game works! Best regards. |
Damn (( seems makefile changes crashed somewhere
сб, 2 февр. 2019 г., 14:57 ElPatas1 <notifications@github.com>:
… @sp193 <https://github.com/sp193>, with this commit after update the
PS2SDK no game works!
At least with the internal HDD all the games got a BSOD.
Best regards.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#188 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAl8SLNnJ8aCS_2bhPnp3tpCiy_Z2O_Dks5vJYshgaJpZM4aaHno>
.
|
I think the problem is with UDNL. I didn't realize that the pointers were not pointers to bytes, so the new code is not very compatible with the original logic. |
Synced with ps2sdk, corrected some logic
Synced with ps2sdk, corrected some logic
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
I just was trying to unify some things - and make them as it is in mainstream ps2sdk. I also fixed some errors which capture modern toolchain. there are still many things to do but at least for now opl can be compiled on modern gcc.