Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of fixes and small improvements #217

Merged
merged 8 commits into from Sep 18, 2019

Conversation

rickgaiser
Copy link
Member

Fix issue #211 tested with:

  • SLES_525.73.Conflict Global Storm
  • SCES_533.26.Shadow of the Colossus
  • SLUS_202.94.Gitaroo Man

Add Makefile targets to simplify testing:

  • make run <- will make opl.elf and send it to the ps2 using ps2client
  • make sim <- will make opl.ef and start is using pcsx2

Replace all instances of printf with LOG. The LOG macro will only add printf statements for debugging versions. So it doesn't waste space for release versions.

Fix sound module trying to "free" builtin sounds. Only "malloc"ed sounds should be freed.

Merge 3 almost identical "Rules.make" files. And also prevent rebuilding files that have not been changed. This caused "make opl.elf" to always rebuild some modules. Compilation is a lot faster now on my slow laptop ;-)

Fix buffer overrun in ioprp_image. We forgot t account for the eesync module size.

…alignment correction is performed."

This reverts commit cd100a2.
Due to alignment the buffer can be overrun by the alignment size (64
bytes).
Some iop modules would always be rebuilt (like cdvdman* and mcemu*).
Slowing down compilation times.
@J013k
Copy link
Contributor

J013k commented Sep 8, 2019

Thanks for lots of improvements.
When this pull request will be merged, I'll also try to test Manhunt (SLES_520.23).

The theme was activated before it was fully loaded. This fix activates
the theme at the end of the loading.
@rickgaiser
Copy link
Member Author

Fix for #216 added.

@rickgaiser
Copy link
Member Author

Those interested can find an automated build of OPL including this PR here:
https://gitlab.com/ps2max/Open-PS2-Loader/-/jobs/296825920/artifacts/browse

@J013k
Copy link
Contributor

J013k commented Sep 17, 2019

I've only tried USB device.

When starting device will set - Auto.
Translation and theme will load flawless.

Problem starts with manual initializing.
When I select thm, save settings, reboot, launch OPL, start device, everything is fine.
When I select lng, save settings, reboot, launch OPL, start device, I've no font:
https://i.postimg.cc/yNrckGxz/OPL-bug.png

When I selected both lng & thm, save settings, reboot, launch OPL, start device,
OPL will freeze:
https://i.postimg.cc/RVYDrvwc/OPL-bug2.png

Translation was taken from this topic:
https://www.psx-place.com/threads/open-ps2-loader-beta-revisions-releases-language-pack.20547/.

So currently loading themes (thm) is working no matter how device will be started,
but something was broke with supporting translation (lng).

Here is how lng support evolved recently:
#210
https://www.psx-place.com/threads/open-ps2-loader-v0-9-3.13415/page-40#post-200411,

Unfortunately currently I don't have time to test at least one of these games.

@KrahJohlito
Copy link
Member

KrahJohlito commented Sep 17, 2019

@J013k
I have a fix for lng, which is causing both issues..seeing how rickgaiser fixed themes helped.. but I’m waiting for this pr to be merged before opening a new one.

Here’s the fix
KrahJohlito@a262ab5

@rickgaiser
Copy link
Member Author

I've tried activating custom languages from usb, but I cannot get it to work correctly, not even the english one. In the debug output I see that only 7 or 8 language texts are loaded. Then in the main menu some texts (probably 7 or 8) are gone. I've triend converting the language files with dos2unix/unix2dos, but that doesn't help.

I think it's better if @KrahJohlito fixes the language issues separately. Please merge this PR.

@ElPatas1 ElPatas1 merged commit 0de42a1 into ps2homebrew:master Sep 18, 2019
@ElPatas1
Copy link
Contributor

Commit merged.

Best regards.

@rickgaiser rickgaiser deleted the for-ifcaro branch May 1, 2020 12:50
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
Lots of fixes and small improvements
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
Lots of fixes and small improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants