Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$add_metadata() should override columns with same name #44

Closed
iferres opened this issue Nov 25, 2020 · 2 comments
Closed

$add_metadata() should override columns with same name #44

iferres opened this issue Nov 25, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@iferres
Copy link
Owner

iferres commented Nov 25, 2020

If I pass a data.frame with a column name that already exist, the actual behaviour is to repeat the column. The desired behaviour is to override existing columns with the same name as the data.frame provided. Also should provide a method to remove columns.
@iferres iferres added enhancement New feature or request bug Something isn't working labels Nov 25, 2020
@iferres
Copy link
Owner Author

iferres commented Jan 18, 2021

Also, add an option to fill empty instances with NA_*. This facilitates adding metadata to a pangenome with hidden (dropped) organisms, although it makes it less safe.

@iferres iferres mentioned this issue Jan 18, 2021
Open
@iferres
Copy link
Owner Author

iferres commented Jan 18, 2021

Also related to #46

@iferres iferres closed this as completed in 24d51aa May 7, 2021
@iferres iferres mentioned this issue Nov 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iferres