Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification is fixed to the page instead to the screen #12

Closed
redhead opened this issue Dec 28, 2012 · 8 comments
Closed

Notification is fixed to the page instead to the screen #12

redhead opened this issue Dec 28, 2012 · 8 comments
Assignees

Comments

@redhead
Copy link

redhead commented Dec 28, 2012

For me the growler notification doesn't have a fixed position to the screen when scrolling down the page.

When it was at the top it was shown only at the top of the whole page not just the vieport, so user couldn't see it when page was scrolled down. Same thing then for bottom offset where it wasn't at the bottom of the viewport when page was scrolled but at a fixed position on the page.

Solution I found is to have the 'position' CSS rule set to 'fixed' instead of 'absolute'.

@longlostnick
Copy link
Owner

Needed to re-open. Adding position fixed breaks the ability to nest inside of other divs with the 'ele' option. What I'm thinking I will do is make the position fixed, but use margin-top/margin-left to position the alert inside the 'ele' instead of the top/left/right/bottom properties. This will take a little more work than I expected.

Here's an example I found of what I'm talking about: http://stackoverflow.com/questions/4962266/css-positionfixed-inside-a-positioned-element

@ghost ghost assigned longlostnick Dec 31, 2012
@redhead
Copy link
Author

redhead commented Dec 31, 2012

And what about leaving current implementation as is but when the 'ele' option is set to 'body' the position will be 'fixed' position (instead of 'absolute')?
I don't know about internal things, but it could be a simple fix.

@longlostnick
Copy link
Owner

That's a good idea! Would keep things simple. I think that's the route I will go, but gimme a day or so to get the fix in.

@redhead
Copy link
Author

redhead commented Dec 31, 2012

Sure, no problem.

@needcaffeine
Copy link

Hi-- has the above mentioned fix already been implemented? Thank you for your work.

longlostnick added a commit that referenced this issue Jan 22, 2013
longlostnick added a commit that referenced this issue Jan 22, 2013
@longlostnick
Copy link
Owner

@needcaffeine nope. I'm sorry I was busy around the holiday and completely forgot! Growls should be fixed if ele is "body", otherwise they will be absolute.

@needcaffeine
Copy link

@ifightcrime Thank you!

@vidhatesachin
Copy link

Thankyou.. setting css position:fixed worked ryt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants