Remove @objc conformance and refactor optional protocol methods to default implementations in protocol extensions. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault implementations in protocol extensions.
ifitdoesntwork
added a commit
that referenced
this pull request
Jan 11, 2016
Remove @objc conformance and refactor optional protocol methods to default implementations in protocol extensions.
|
Nice refactoring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove @objc conformance and refactor optional protocol methods to default implementations in protocol extensions. Useful if you want to create a protocol ExpandingUserInterface and a protocol extension with default implementations for all expandable ViewControllers (e.g. extension ExpandingUserInterface where Self: UIViewController). You can then implement default implementations for only those animation adapter methods that you need while leaving the rest as defined in the default implementations of DAExpandAnimation (no ops...).