Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not work on gnome-shell 3.20.4 #13

Closed
craigwu9 opened this issue Jul 27, 2017 · 5 comments
Closed

not work on gnome-shell 3.20.4 #13

craigwu9 opened this issue Jul 27, 2017 · 5 comments

Comments

@craigwu9
Copy link

craigwu9 commented Jul 27, 2017

When I want to open config dialog from gnome-tweak-tool, it pop a dialog and show message as below:

SyntaxError: illegal character

Stack trace:
@/home/***/.local/share/gnome-shell/extensions/randomwallpaper@iflow.space/prefs.js:19
Application<._getExtensionPrefsModule@resource:///org/gnome/shell/extensionPrefs/main.js:74
wrapper@resource:///org/gnome/gjs/modules/lang.js:178
Application<._selectExtension@resource:///org/gnome/shell/extensionPrefs/main.js:89
wrapper@resource:///org/gnome/gjs/modules/lang.js:178
Application<._onCommandLine@resource:///org/gnome/shell/extensionPrefs/main.js:238
wrapper@resource:///org/gnome/gjs/modules/lang.js:178
main@resource:///org/gnome/shell/extensionPrefs/main.js:376
@:1

And the gnome-tweak-tool shows failed to load the extension.
Gnome-shell version is 3.20.4

@ifl0w
Copy link
Owner

ifl0w commented Jul 27, 2017

Did you install the version from https://extensions.gnome.org/extension/1040/random-wallpaper/
or did you install it directly from this repository?

The version from extensions.gnome.org was broken and I submitted a new one which has to be reviewed.
The code in this repository on the master branch should work on gnome 3.20.

@craigwu9
Copy link
Author

I installed directly from this git repository.

@ifl0w
Copy link
Owner

ifl0w commented Jul 27, 2017

I am sorry but I am not able to reproduce this bug. Just tested the extension again and it worked flawless on openSUSE 42.3.

Which distribution do you use? And did you install the the extension with the install script or manually? And check if you are really on the latest commit on the master branch since your problem sounds like the one that has been addressed in #8.

screenshot from 2017-07-27 13-18-08

@craigwu9
Copy link
Author

It's weird, I just cloned today. It seems I did not got lasted version. I pulled again, It works.

@ifl0w
Copy link
Owner

ifl0w commented Jul 27, 2017

Well ok :) At least I don't have to release a hotfix :D

@Governa Governa mentioned this issue Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants